-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestions to improve user experienced #1
Comments
Potential speed ups?
UPDATE: the rare cell-type computations, perplexity, etc take a while if they are computed using a new corpus. But because we are interested in the same corpus we fit an LDA model too, we don't need to indicate a new corpus. So this speeds things up a little bit. |
Maybe a progress bar when running vizAllTopics? I was plotting ~3500 spots (per visium square), it takes more than 5 min for image to show. At some point I was wondering if my R froze or it is the normal behavior. |
Hi JPingLin, Thanks for the suggestion! Yes - I have noticed that Let me know if you have any other questions or suggestion, |
Hi Brendan, thanks for the great tool, the installation was smooth and error free off the bat! I have one question and one suggestion: One suggestion, I think it will be useful to incorporate a function to flip the coordinates easily in plots. I know this might be related to the issue of (0, 0) starting from upper left, or lower left corner in axis from different program. And might be related to how initially pixel/spot data was prepared coming out from specific platform. Right now the plots are always upside down for me if using visium output. |
Hi JPingLin, Your understanding is correct - by default, genes present in less than 5% of the total pixels in a given dataset will be removed and not included in the final corpus used as input into STdeconvolve. The motivation behind this filtering step is to remove genes that were poorly captured across pixels in the ST experiment, and may not be accurately assigned to clusters of tightly occurring and non-overlapping expressed genes. Depending on the dataset, however, 5% can actually represent a large number of pixels, and so perhaps a lower threshold can also be appropriate, especially if the goal is to identify and include overdispersed genes that may be marking rare cell-types. Using
where Alternatively, you can also use
If there is a list of cell marker genes you would like to include in addition to the overdispersed genes, you could first feature select for the overdispersed genes using
This is a lot of information, so let me know if any of this doesn't make sense or you have additional questions. |
This is definitely a good idea and it is most likely an issue with the relative placement of (0,0) with respect to the original image and the plotting coordinate system used in R. Will see if I can come up with a simple function to transform. In the meantime, one could do something like this:
to essentially flip the plotted pixels upside down. Conversely, you could do the same thing with the x-coordinates of the pixels. |
As I'm using
STdeconvolve
on new datasets, here are some enhancements that I believe will help improve the user experience. This is a running list. Please feel free to add and check off as needed.fitLDA
would benefit from a progress bar that shows ifverbose=TRUE
. See https://github.com/r-lib/progressvizAllTopics
should check ifgroups
is a factor and cast if not (otherwise throws errors)vizAllTopics
would benefit from automatically setting an appropriater
based on the scale ofpos
unless users override with a specific choice (ex.max(0.5, max(pos)/nrow(pos)*10
or something)restrictCorpus
should limit the number of genes to some top most variable set (similar to howveloviz
does it) in the event there are too many features (ex > 1000 by default or some other user-specified number)The text was updated successfully, but these errors were encountered: