Skip to content
This repository has been archived by the owner on Jan 9, 2019. It is now read-only.

PHP7 Compat #33

Open
amenk opened this issue Feb 8, 2016 · 4 comments
Open

PHP7 Compat #33

amenk opened this issue Feb 8, 2016 · 4 comments

Comments

@amenk
Copy link

amenk commented Feb 8, 2016

I am getting various fatal errors on vendor:publish (2.0 branch)

PHP Fatal error:  Declaration of JeroenG\LaravelPhotoGallery\Adapters\Eloquent\EloquentPhotoAdapter::add(JeroenG\LaravelPhotoGallery\Entities\Photo $photo) must be compatible with JeroenG\LaravelPhotoGallery\Contracts\PhotoAdapter::add(Photo $photo) in /home/self/example/vendor/jeroen-g/laravel-photo-gallery/src/Adapters/Eloquent/EloquentPhotoAdapter.php on line 10
PHP Stack trace:
@amenk
Copy link
Author

amenk commented Feb 8, 2016

Basically I think the adapters have to use the Contract in the parameter list
Trying to fix this, but comments are appreciated.

@amenk
Copy link
Author

amenk commented Feb 8, 2016

see #34

@Jeroen-G
Copy link
Owner

Jeroen-G commented Feb 9, 2016

Does the PR fix this?

@amenk
Copy link
Author

amenk commented Feb 9, 2016

Yes
Am 09.02.2016 6:28 nachm. schrieb "JeroenG" [email protected]:

Does the PR fix this?

—
Reply to this email directly or view it on GitHub
#33 (comment)
.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amenk @Jeroen-G