Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove DSP dependency #176

Closed
MikaelSlevinsky opened this issue Jul 20, 2022 · 4 comments
Closed

Remove DSP dependency #176

MikaelSlevinsky opened this issue Jul 20, 2022 · 4 comments

Comments

@MikaelSlevinsky
Copy link
Member

Removing DSP from FastTransforms reduces the load time from 3.7 s to 2.8 s for me, a 25% savings. @dlfivefifty, is there any downstream reason not to remove DSP?
@dlfivefifty
Copy link
Member

I thought we need it for conv ?

@MikaelSlevinsky
Copy link
Member Author

If JuliaDSP/DSP.jl#477 gets merged, then generic convolution will have nothing to do with this repository.

@MikaelSlevinsky
Copy link
Member Author

This issue will be closed today with a patch release since JuliaDSP/DSP.jl#477 has been merged, FastTransforms re-exports GenericFFT, and ToeplitzMatrices (a FastTransforms dependency) has been tagged (JuliaLinearAlgebra/ToeplitzMatrices.jl@c6f3a24) to ensure the newest DSP patch or greater, [0.7.7, 0.8.0), is loaded.

@MikaelSlevinsky
Copy link
Member Author

That is, no loss of features (no breaking changes) for the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dlfivefifty @MikaelSlevinsky