-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zenodo release failed #612
Comments
I've disabled and re-enabled DSP.jl in Zenodo, which has re-created the webhook. Now there is a successful "ping" under "Recent Deliveries". So hopefully, this will work in the future. Not sure how/if we can trigger this for this existing, missed releases. |
Perhaps you could try adapting the code from this link? |
Just done that and it has successfully added a bunch of old versions, but for 0.7.9 and 0.8.0, I got:
I'm confused. |
And when sorted by version 0.6.2 is at the top, followed by 0.5.2...very weird |
Apparently it's sorted by the date it was added to Zenodo, not the publication date, and the bunch of additions that happened in a short time interval are just sorted randomly. Sorting by publication date gives a reasonable list. But I haven't found an option to make that sorting order the default. BTW, the link in the README seems to be specific to v0.7.9. Once we have Zenodo giving the proper version as the latest, we should update it to https://doi.org/10.5281/zenodo.7016211, which "represents all versions, and will always resolve to the latest one." |
Hm... https://zenodo.org/account/settings/github/repository/JuliaDSP/DSP.jl lists v0.7.10 and v0.8.0 as failed releases (due to "401 Bad credentials") - probably that's why they cannot be created (again) now. Does that mean anyone can block any future releases from appearing on Zenodo by sending a respective request with a random (invalid) token? That would be... quite bad. |
So based on https://gist.github.com/mkitti/b8f6f0568122eabb234d9ce6011210e2, I've sent "deleted" events to Zenodo for the two missing releases, which received a 202 "Accepted" but apparently were just ignored by Zenodo. I've also changed v0.7.10 to pre-release and back which made Github call the Zenodo webhook, but that also resulted in a 409 "The release has already been received." Maybe manually adding those releases to Zenodo could work, but I'm not too motivated right now... |
Sounds serious, yeah. Let's just file a bug report on the Zenodo repo and call it a day? |
I've contacted Zenodo support about this and they've added the two missing releases and also offered to fix the ordering. I've happy accepted that, should hopefully happen in the foreseeable future. |
The releases of 0.7.10 and 0.8 aren't reflected in zenodo. Apparently the request failed with
"errors": "401 Bad credentials"
, so the webhook was probably triggered except a secret / access token was missing, but then I don't see anything under Webhooks / Recent Deliveries.So that's weird.
The text was updated successfully, but these errors were encountered: