Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose resample_filter optional arguments in resample, FIRFilter #621

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

wheeheee
Copy link
Member

Just passes on arguments in the most obvious manner.
Additionally, make some FIRKernel fields const, and removed unnecessary @inbounds, and added restrictions to pad_length in filtfilt to prevent oob.
Also wrote some minimal documentation for resample_filter. Need some help here, I just guessed the meaning of rel_bw...

Should help with #620

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.12%. Comparing base (06f8776) to head (0148012).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #621      +/-   ##
==========================================
+ Coverage   97.97%   98.12%   +0.15%     
==========================================
  Files          19       19              
  Lines        3254     3258       +4     
==========================================
+ Hits         3188     3197       +9     
+ Misses         66       61       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@martinholters martinholters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, but if the missing coverage reports are legitimate, some more tests are in order.

src/Filters/design.jl Outdated Show resolved Hide resolved
src/Filters/design.jl Outdated Show resolved Hide resolved
src/Filters/stream_filt.jl Outdated Show resolved Hide resolved
src/Filters/filt.jl Show resolved Hide resolved
@martinholters
Copy link
Member

How do you feel about bumping the version to 0.8.1 as part of this PR and tagging a new release once it's in?

@wheeheee
Copy link
Member Author

How do you feel about bumping the version to 0.8.1 as part of this PR and tagging a new release once it's in?

Sure, why not.

Also, do you think rel_bw and attenuation should be keyword arguments? Makes it harder to accidentally mess up.

Copy link
Member

@martinholters martinholters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooof, +343 -267 lines for a relatively simple change due to code reorganization and tangential changes. That really makes code review unnecessarily hard. I'll try to find time/motivation for a closer look at this, but if you get impatient, you could help by moving NFC changes like the introduction of reference data or the like to separate PRs.

src/Filters/stream_filt.jl Show resolved Hide resolved
src/Filters/stream_filt.jl Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants