Operation point solution from PowerModels.jl #118

SabineAuer · 2020-08-27T14:41:34Z

No description provided.

Adding function for dictionary creation only for the lines.

Nodes start: SlackAlgebraic, PVAlgebraic and PQAlgebraic.

codecov · 2020-08-27T15:21:17Z

Codecov Report

Merging #118 (c37fe14) into master (53815c7) will decrease coverage by 15.44%.
The diff coverage is 0.50%.

@@             Coverage Diff             @@
##           master     #118       +/-   ##
===========================================
- Coverage   89.59%   74.14%   -15.45%     
===========================================
  Files          40       41        +1     
  Lines         903     1079      +176     
===========================================
- Hits          809      800        -9     
- Misses         94      279      +185

Impacted Files	Coverage Δ
src/PowerDynamics.jl	`100.00% <ø> (ø)`
src/lines/PiModelLine.jl	`100.00% <ø> (ø)`
src/operationpoint/power_flow.jl	`0.00% <0.00%> (ø)`
src/operationpoint/operationpoint.jl	`88.88% <20.00%> (-7.03%)`	⬇️
src/parsers/JsonParser.jl	`96.22% <0.00%> (+13.79%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53815c7...715d38b. Read the comment docs.

SabineAuer · 2020-08-28T09:52:58Z

@lekic-aleksandra @luap-pik : I added a small test script so we can see how the power flow works and added PowerModelsACDC as a dependency. For me this throws a compilation error and further internal package errors for PowerModelsACDC. Can you reproduce this?

SabineAuer

The CI shows that the problem I described seems to hold for versions of Julia larger equal 1.4

SabineAuer · 2020-08-28T09:55:05Z

src/operationpoint/power_flow.jl

+        dict["va"] = 0
+        dict["base_kv"] = 1e-3
+
+        if isa(node, PQAlgebraic)


could we also use multi-dispatching here like calling function make_bus_ac(data :: Dict{String, Any}, node::PQAlgebraic) and so on?

lekic-aleksandra · 2020-08-30T10:56:50Z

Yes, we can do that. I just did not want to make additional functions inside models. Can somebody help me with the code organization?

…

On Fri, Aug 28, 2020 at 2:05 PM SabineAuer ***@***.***> wrote: ***@***.**** commented on this pull request. The CI shows that the problem I described seems to hold for versions of Julia larger equal 1.4 ------------------------------ In src/operationpoint/power_flow.jl <#118 (comment)> : > + function make_bus_ac(data :: Dict{String, Any}, node) + key_e = length(data["bus"])+1 + (data["bus"])[string(key_e)] = Dict{String, Any}() + dict = (data["bus"])[string(key_e)] + dict["source_id"] = Any["bus", key_e] + dict["index"] = key_e + dict["bus_i"] = key_e + dict["zone"] = 1 + dict["area"] = 1 + dict["vmin"] = 0.9 + dict["vmax"] = 1.1 + dict["vm"] = 1 + dict["va"] = 0 + dict["base_kv"] = 1e-3 + + if isa(node, PQAlgebraic) could we also use multi-dispatching here like calling function make_bus_ac(data :: Dict{String, Any}, node::PQAlgebraic) and so on? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#118 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKDAQMUJCM7LFCJBPEUVEX3SC6MO5ANCNFSM4QNCH3VA> .

luap-pik · 2020-09-01T09:59:42Z

Hi! Sure, I think that @SabineAuer 's suggestion above to split the if/else in separate functions with the use of multi-dispatching could be worth a try.

First, however, I'm a bit worried about the failing tests for Julia 1.4 that were mentioned.
Can you post the error message?

Project.toml

luap-pik · 2020-09-01T10:16:33Z

OK, I ran the tests locally on Julia 1.5 and could not reproduce any error :-)
I added Ipopt and PowerModels to the Project.toml. I'll push this, then maybe
the CI will pass.

lekic-aleksandra · 2020-09-01T10:19:32Z

Ok, I am not sure how do you update .toml file? Before I did it by running a script. Now, I did not concentrate on that. P.S. I need help with making it distributed in functions. I don't want to make it "ugly".

…

On Tue, Sep 1, 2020 at 12:16 PM Paul Schultz ***@***.***> wrote: OK, I ran the tests locally on Julia 1.5 and could not reproduce any error :-) I added Ipopt and PowerModels to the Project.toml. I'll push this, then maybe the CI will pass. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#118 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKDAQMUUZNS5JIKYBEAYXPDSDTCY7ANCNFSM4QNCH3VA> .

luap-pik · 2020-09-01T10:22:27Z

In general, when you are in a local environment and do ]add Package this adds a dependency in the Project.toml.

luap-pik · 2020-09-01T10:22:51Z

OK, I can make a sketch for separating it into functions :-)

luap-pik · 2020-09-01T11:09:55Z

@lekic-aleksandra here is my suggestion.
Now, I get the following error message from run_pf.

test = power_flow(powergrid)
ERROR: MethodError: no method matching set_optimizer(::JuMP.Model, ::Type{Ipopt.Optimizer})
Closest candidates are:
  set_optimizer(::JuMP.Model, ::JuMP.OptimizerFactory; bridge_constraints) at /home/paul/.julia/packages/JuMP/iGamg/src/optimizer_interface.jl:35

Do you have an idea what's causing this?

Direction for PowerModels is different than in PowerDynamics. Load P and Q are multiplied with -1.

lekic-aleksandra · 2020-09-01T12:26:33Z

I am not sure. Power flow gives now exactly the same solution as other methods. I use PowerModelsACDC for monitoring losses, there is a possibility to extend to HVDC.

…

On Tue, Sep 1, 2020 at 1:10 PM Paul Schultz ***@***.***> wrote: @lekic-aleksandra <https://github.com/lekic-aleksandra> here is my suggestion. Now, I get the following error message from run_pf. test = power_flow(powergrid) ERROR: MethodError: no method matching set_optimizer(::JuMP.Model, ::Type{Ipopt.Optimizer}) Closest candidates are: set_optimizer(::JuMP.Model, ::JuMP.OptimizerFactory; bridge_constraints) at /home/paul/.julia/packages/JuMP/iGamg/src/optimizer_interface.jl:35 Do you have an idea what's causing this? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#118 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKDAQMRR2QEI3HSUWHPYZ2DSDTJBDANCNFSM4QNCH3VA> .

… alekic

SabineAuer · 2020-09-01T13:07:48Z

Hi! Sure, I think that @SabineAuer 's suggestion above to split the if/else in separate functions with the use of multi-dispatching could be worth a try.

First, however, I'm a bit worried about the failing tests for Julia 1.4 that were mentioned.
Can you post the error message?

@luap-pik : it is the same error message as in the Travis CI, see here https://travis-ci.org/github/JuliaEnergy/PowerDynamics.jl/jobs/723063577#L894

… alekic

SabineAuer · 2020-09-11T16:29:04Z

@luap-pik @lekic-aleksandra : The issue with PowerModelsACDC seems fixed and a new patch with the fix will be released soon. I added the master of PM ACDC locally and the compilation error disappeared.

luap-pik · 2020-09-13T20:26:21Z

@SabineAuer that's great! thank's for posting the issue. Now the path to use PM ACDC is free :-)

… alekic

SabineAuer · 2020-10-20T09:29:20Z

@luap-pik : I started the test for PowerModels based on our test_example.jl
In the test, the comparison between "find_operationpoint" and the PowerModels solution delivers different results (see print statement here) for the voltage of the algebraic load node. What is your opinion on this?

luap-pik · 2020-10-21T11:57:46Z

In the link it seems that they are not the same because the load flow solution in PowerModels does not converge, it says EXIT: Converged to a point of local infeasibility. Problem may be infeasible.
I will have a look at this.

luap-pik · 2020-10-24T23:02:58Z

test/operationpoint/PowerModelsIntegration.jl

+# compare branch data
+for (k, v) in data["branch"]
+    @test all(keys(v) .== keys(data_2["branch"][k]))
+    @test all(values(v) .== values(data_2["branch"][k]))


@SabineAuer the problem seems to be, that for the dict, the PowerModels data is not correctly created. As far as I can see, the fromand to field are strings and not numbers, apparently this does not work with PM since there does not seem to be any other difference between dataand data_2.

luap-pik · 2020-12-07T13:26:02Z

@SabineAuer some of the new tests seem to be still failing

SabineAuer · 2020-12-23T10:15:45Z

for PowerDynamics line dicts and node dicts we run into an error in this function of PowerModels: https://github.com/lanl-ansi/PowerModels.jl/blob/54715c6ffe6d56357831b3e9b50f6ecf57b6eace/src/core/base.jl#L31

Dictionary representation enabled!

Aleksandra Lekic-Vervoort added 3 commits August 16, 2020 20:02

PowerModelsACDC init

96758a4

Adding function for dictionary creation only for the lines.

Update power_flow.jl

83a837c

Nodes start: SlackAlgebraic, PVAlgebraic and PQAlgebraic.

update

4251aba

SabineAuer added enhancement New feature or request do not merge yet labels Aug 27, 2020

SabineAuer assigned lekic-aleksandra Aug 27, 2020

SabineAuer linked an issue Aug 27, 2020 that may be closed by this pull request

Interface PowerModels.jl for parsing files #92

Closed

Merge branch 'master' into alekic

4c768d8

adding depencies, script for testing

7f1ffc8

Merge branch 'master' into alekic

af61fe9

SabineAuer commented Aug 28, 2020

View reviewed changes

Aleksandra Lekic-Vervoort added 2 commits August 31, 2020 22:38

Power flow fix

f303d8c

Update power_flow.jl

042302e

luap-pik reviewed Sep 1, 2020

View reviewed changes

Project.toml Show resolved Hide resolved

added dependencies

fadf488

restructuring

13de6fe

Fix for PQAlgebraic

8696783

Direction for PowerModels is different than in PowerDynamics. Load P and Q are multiplied with -1.

SabineAuer added 2 commits September 1, 2020 14:58

adhusting example

3f350d5

Merge branch 'alekic' of github.com:JuliaEnergy/PowerDynamics.jl into…

189f467

… alekic

Aleksandra Lekic and others added 3 commits September 9, 2020 15:20

VSI

54f7767

VSI

3d2621b

Merge branch 'alekic' of github.com:JuliaEnergy/PowerDynamics.jl into…

cd9afb7

… alekic

luap-pik and others added 9 commits September 16, 2020 18:53

Merge branch 'master' into alekic

73fddef

todos from PD meeting

f04ba76

Merge branch 'alekic' of github.com:JuliaEnergy/PowerDynamics.jl into…

a1cff02

… alekic

WIP test for PowerModels operation point search

ca0984e

small bug

5d0fbc4

Merge branch 'master' into alekic

c37fe14

Merge branch 'alekic' of github.com:JuliaEnergy/PowerDynamics.jl into…

e749105

… alekic

modifying test

0a3e17d

updates on test

e7b907c

located possible error

06d3931

luap-pik reviewed Oct 24, 2020

View reviewed changes

Merge branch 'master' into alekic

715d38b

SabineAuer and others added 3 commits March 17, 2021 14:29

comments from meeting

456691b

Merge branch 'master' into alekic

74f6274

Solution dictionary

39fc510

Dictionary representation enabled!

SabineAuer linked an issue Mar 31, 2021 that may be closed by this pull request

Adding classic power flow algorithm for initialisation #144

Open

SabineAuer mentioned this pull request Mar 31, 2021

Adding classic power flow algorithm for initialisation #144

Open

SabineAuer added 2 commits April 22, 2021 15:42

updating tests

8dacfe7

removing .m files

c005eed

SabineAuer merged commit d7d8d0f into master Apr 22, 2021

SabineAuer deleted the alekic branch May 6, 2021 13:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Operation point solution from PowerModels.jl #118

Operation point solution from PowerModels.jl #118

SabineAuer commented Aug 27, 2020

codecov bot commented Aug 27, 2020 •

edited

Loading

SabineAuer commented Aug 28, 2020

SabineAuer left a comment

SabineAuer Aug 28, 2020

lekic-aleksandra commented Aug 30, 2020 via email

luap-pik commented Sep 1, 2020

luap-pik commented Sep 1, 2020

lekic-aleksandra commented Sep 1, 2020 via email

luap-pik commented Sep 1, 2020

luap-pik commented Sep 1, 2020

luap-pik commented Sep 1, 2020

lekic-aleksandra commented Sep 1, 2020 via email

SabineAuer commented Sep 1, 2020

SabineAuer commented Sep 11, 2020

luap-pik commented Sep 13, 2020

SabineAuer commented Oct 20, 2020

luap-pik commented Oct 21, 2020

luap-pik Oct 24, 2020

luap-pik commented Dec 7, 2020

SabineAuer commented Dec 23, 2020

Operation point solution from PowerModels.jl #118

Operation point solution from PowerModels.jl #118

Conversation

SabineAuer commented Aug 27, 2020

codecov bot commented Aug 27, 2020 • edited Loading

Codecov Report

SabineAuer commented Aug 28, 2020

SabineAuer left a comment

Choose a reason for hiding this comment

SabineAuer Aug 28, 2020

Choose a reason for hiding this comment

lekic-aleksandra commented Aug 30, 2020 via email

luap-pik commented Sep 1, 2020

luap-pik commented Sep 1, 2020

lekic-aleksandra commented Sep 1, 2020 via email

luap-pik commented Sep 1, 2020

luap-pik commented Sep 1, 2020

luap-pik commented Sep 1, 2020

lekic-aleksandra commented Sep 1, 2020 via email

SabineAuer commented Sep 1, 2020

SabineAuer commented Sep 11, 2020

luap-pik commented Sep 13, 2020

SabineAuer commented Oct 20, 2020

luap-pik commented Oct 21, 2020

luap-pik Oct 24, 2020

Choose a reason for hiding this comment

luap-pik commented Dec 7, 2020

SabineAuer commented Dec 23, 2020

codecov bot commented Aug 27, 2020 •

edited

Loading