Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retcodes to Symbols deprecated in Julia v1.9 #15

Open
henrikjaerleblad opened this issue Jan 9, 2023 · 2 comments
Open

Retcodes to Symbols deprecated in Julia v1.9 #15

henrikjaerleblad opened this issue Jan 9, 2023 · 2 comments

Comments

@henrikjaerleblad
Copy link
Contributor

When orbit-integrating now (Julia v1.9)(using orbit.jl/integrate()), one gets the following warning

@Warning: Backwards compatability support of the new return codes to Symbols will be deprecated with the Julia v1.9 release. Please see https://docs.sciml.ai/SciMLBase/stable/interfaces/Solutions/#retcodes for more information

If one reads the content provided with the link, I interpret it as we need to change e.g. sol.retcode == :Success to SciMLBase.successful_retcode(sol) everywhere in orbits.jl (and callbacks.jl?). That is, remove Symbol syntax

@lstagner can you fix this?
@lstagner
Copy link
Collaborator

Thats annoying. For now we could just put a compat limit.

@henrikjaerleblad
Copy link
Contributor Author

Alright let's do that for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lstagner @henrikjaerleblad