Issues with spaces in a file, this fixes it #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rting with space. Also now allows spaces at the end of the line. Improved reader code a bit.
|
Cool, that was fast, thanks! Would you mind tagging a release (I guess it should be a patch), I'd like to use this in a workshop which I give next Monday. |
|
Thank you for the PR in the first place ! Ok, i'm on it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to read the ascii-grid in https://data.geo.admin.ch/ch.swisstopo.digitales-hoehenmodell_25/data.zip and it didn't work because:
This PR fixes this. Also simplified the reader a bit.
PS: I implemented some ascii reader some time ago too, also for the binary files. In case you're interested: https://github.com/eth-vaw-glaciology/GlacioTools.jl/blob/50c96b10399783b9b23e56455730db2be3a41ba2/src/misc-file-readers.jl#L131