DiskArrays for CFVariable #9
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 14, 2023
tcarion
changed the title
|
Why is it hard to extend |
|
This |
|
@Alexander-Barth did you try at this after our last discussion? (I'm realising GRIBDatasets.jl is a bit broken without this, and the hacks I've done to make it work in Rasters are not holding up well. SO I can work on this PR a bit to get it done, if that would be helpful, and if the plan is to merge it) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in issue #8.
It currently requires the implementing modules to extend the
Base.parentmethod for the Variables, that should return the reference to the underlying array. That makes sense for GRIBDatasets, but I don't think it will be that easy for NCDatasets... This PR is needed for GRIBDataset in Raster to work, but simultaneously, it breaks NCDatasets. So consider this PR has a shared experimentation for now :-)