Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

license as MIT? #15

Closed
visr opened this issue Oct 15, 2023 · 3 comments
Closed

license as MIT? #15

visr opened this issue Oct 15, 2023 · 3 comments

Comments

@visr
Copy link
Member

visr commented Oct 15, 2023

Hi there, I'm just going through all the JuliaGeo license files to standardize the formats, and I noticed this repository is the only non-MIT repository in all of JuliaGeo.

Of course Apache-2.0 is also a well known permissive license, but for consistency I was wondering if there is a reason to deviate here? If you wish to also license it as Apache-2.0, perhaps it can be dual licensed under Apache-2.0 and MIT as is common in the Rust community?

@tcarion
Copy link
Member

tcarion commented Oct 18, 2023

Hi!
The reason behind the Apache-2.0 license is that GRIBDatasets originally took some code from the old CfGRIB package, which was Apache. Since I'm unfamiliar with how licenses work, I thought I had to take the same one. What does it imply to change the license? Can I just change it right away?

@visr
Copy link
Member Author

visr commented Oct 19, 2023

I see, thanks. Since you are the only contributor right now, you can just change the license yourself. I see you already link to cfgrib.jl in the readme and mention you adapted the code, that's always a good idea to give credit. The licenses are so similar that in practice I don't really think there's much of an issue. If the source would be GPL it would.

If you prefer to stick to the Apache license it's also fine by me, then we can just close this issue.

@tcarion
Copy link
Member

tcarion commented Oct 23, 2023

Alright, thanks, I agree with changing the license for consistency!

tcarion added a commit that referenced this issue Nov 16, 2023
tcarion added a commit that referenced this issue Nov 16, 2023
@tcarion tcarion closed this as completed Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants