allow to use a different masking value than missing #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think that's great, thank you for the PR ! |
Alexander-Barth
force-pushed
the
main
branch
from
dcc130f to
7192aec
Compare
|
Sorry @Alexander-Barth, I think I forgot to merge this ! Could you reopen it ? |
|
Oh, sorry. I just synchronized my branch with your main. I forgot that this was not yet merged. PR got closed automatically by the syncing the branches. I will re-open or make a new PR. |
|
OK, just clicking on reopen was enough to revive the PR :-) |
tcarion
approved these changes
Feb 16, 2024
|
Thanks and have a nice week-end! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently missing values (and fill values) are loaded as
missingin Julia. For some use cases, it is preferable to use different special values likeNaNs (e.g. for GPUs, or interfacing with other C libraries).This PR allows the user to e.g. use
NaNeither per variable or per datasets.What do you think?