Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

to_points #26

Open
LanaLubecke opened this issue Dec 8, 2023 · 3 comments
Open

to_points #26

LanaLubecke opened this issue Dec 8, 2023 · 3 comments

Comments

@LanaLubecke
Copy link
Contributor

In the utils.jl file, the function to_points is not working properly. In addition to fixing it, it would be helpful to add an optional argument "repeat_last" which is a boolean. This boolean would specify whether or not to_points returns an array where the first and the last point are the same or not. If "repeat_last" = true, then if the first and last point are not already the same, to_point adds the first point again to the end of the array.

@rafaqz
Copy link
Member

rafaqz commented Dec 9, 2023

Sounds good to me

@asinghvi17
Copy link
Member

It looks like collect(flatten(GI.PointTrait, GO.tuples(geom))) has superseded to_points? We can implement it in that form if it's easier.

@rafaqz
Copy link
Member

rafaqz commented Apr 1, 2024

There should be a faster way that avoids the rebuilds in tuples

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants