Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Superfluous error when parsing old-style class object in v7.3 #197

Closed
Jeroen-van-der-Meer opened this issue Feb 2, 2024 · 1 comment
Closed

Comments

@Jeroen-van-der-Meer
Copy link
Contributor

Jeroen-van-der-Meer commented Feb 2, 2024

If you save an old-style Matlab object (i.e. created in an @ClassName folder, before classdef was a thing) in a v7.3 file, MAT.jl throws an error saying it cannot read from a non-struct group (cf. line 232 of MAT_HDF5.jl). As a matter of fact, it appears that Matlab saves these objects 'as if' they are structs, and indeed the objects that I have appear to be read just fine if I manually remove the error and let the code continue.

Instead of throwing an error, I would propose giving a warning, such as

@warn "Unknown non-struct group of type $mattype detected; attempting to read as struct"

cf. also associated PR

@musm
Copy link
Member

musm commented May 20, 2024

closed by #198

@musm musm closed this as completed May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants