-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor compressors to be in separate files #153
Conversation
Refactors each compressor into a single file and the abstract API + NoCompressor to `Compressors/Compressors.jl`. Also adds API docs for the Compressor API in case people want to do that. Future work may also explore making this compliant with Interfaces.jl so that we have a way to test that all compressors are compliant.
Pull Request Test Coverage Report for Build 10492471554Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
TODO: there must be a better solution than this!
All new filters (including fletcher32) will be in a new PR! |
Co-authored-by: Anshul Singhvi <[email protected]>
That's strange - tests are all passing, but the build failed when it came time to upload the codecov data, saying the job was already closed. |
(this line repeats in every log from the failed CI) |
Is this ready to be merged? Or do you want to fix something in the CI pipeline first? |
Let's merge this, I'll fix the pipeline in another PR. |
This PR reformats the compressors to be in a folder with separate files, and documents the "compressor API".
(Previous commits added the fletcher32 filter as a compressor, but on review that should be a filter so I'll put it in a new PR.)