Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TOML.print into buffer before writing to file #43

Merged
merged 1 commit into from
Feb 21, 2024
Merged

TOML.print into buffer before writing to file #43

merged 1 commit into from
Feb 21, 2024

Conversation

fonsp
Copy link
Member

@fonsp fonsp commented Feb 21, 2024

You usually want to TOML.print into a buffer before writing to the file, because TOML might throw in the middle of a TOML.print, and you don't want to end up with a half-written toml file in this case.

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (8c26155) 33.72% compared to head (495e29f) 33.72%.

Files Patch % Lines
src/local_plotly_library.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #43   +/-   ##
=======================================
  Coverage   33.72%   33.72%           
=======================================
  Files          12       12           
  Lines         255      255           
=======================================
  Hits           86       86           
  Misses        169      169           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@disberd
Copy link
Member

disberd commented Feb 21, 2024

Good to know, thanks!

@disberd disberd merged commit 58f81ad into main Feb 21, 2024
3 of 5 checks passed
@disberd disberd deleted the toml-sprint branch February 21, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants