Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ScopedValues for flags to set #54

Merged
merged 7 commits into from
Aug 6, 2024
Merged

Use ScopedValues for flags to set #54

merged 7 commits into from
Aug 6, 2024

Conversation

disberd
Copy link
Member

@disberd disberd commented Aug 6, 2024

Moved some of the Ref into ScopedValues

The PLOTLY_VERSION ScopedValue can not at the moment be used to change the displayed plotly version for a single plot, as the scope where the value is changed ends before the plot object is sent to the display with show.

This new ScopedValue can instead be used to modify the version used by PlotlyKaleido.savefig to set the plotly version in the kaleido process.
Currently, the savefig with a PlutoPlotly object checks that the kaleido process has the correct version and restarts it with the correct one otherwise

The SKIP_FLOAT32 to control conversion during preprocessing is also now a ScopedValue

Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.89%. Comparing base (52aed10) to head (4425a4a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
- Coverage   90.33%   89.89%   -0.44%     
==========================================
  Files          12       12              
  Lines         269      287      +18     
==========================================
+ Hits          243      258      +15     
- Misses         26       29       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@disberd disberd merged commit 73b670d into main Aug 6, 2024
6 checks passed
@disberd disberd deleted the scoped_values branch August 6, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should migrate to Scratch.jl to handle location of downloaded plotly library
1 participant