Use muladd in aleph calculation in _quantile to avoid some rounding errors #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreasnoack
force-pushed
the
an/quantilemuladd
branch
from
2ef32f8 to
003b54c
Compare
andreasnoack
changed the title
andreasnoack
force-pushed
the
an/quantilemuladd
branch
from
003b54c to
ee29e57
Compare
errors. In some cases when aleph is an integer (in exact) arithmetic, the calculation of aleph via m can introduce some rounding errors that makes the value non-integer. Using muladd avoids this in some cases.
andreasnoack
force-pushed
the
an/quantilemuladd
branch
from
ee29e57 to
44d51c7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #184 +/- ##
=======================================
Coverage 96.65% 96.65%
=======================================
Files 2 2
Lines 448 448
=======================================
Hits 433 433
Misses 15 15 ☔ View full report in Codecov by Sentry. |
nalimilan
reviewed
Jan 2, 2025
Co-authored-by: Milan Bouchet-Valat <[email protected]>
nalimilan
approved these changes
Jan 3, 2025
|
My guess is that this broke the doctests on some julia CI workers (JuliaLang/julia#57238 (comment)). I haven't verified. |
nalimilan
added a commit
that referenced
this pull request
Feb 4, 2025
We should have updated the doctests when improving behavior at #184.
nalimilan
added a commit
that referenced
this pull request
Feb 4, 2025
We should have updated the doctests when improving behavior at #184.
Merged
|
Indeed. See #188. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases when aleph is an integer (in exact) arithmetic, the calculation of aleph via m can introduce some rounding errors that makes the value non-integer. Using muladd avoids this in some cases.