Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ForwardDiff derivative of NaNMath.pow #1400

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

devmotion
Copy link
Contributor

Fixes #1399.

The PR basically copies JuliaDiff/ForwardDiff.jl#717

@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 6.42%. Comparing base (6202fa4) to head (e3bf321).
Report is 52 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #1400      +/-   ##
=========================================
+ Coverage    3.95%   6.42%   +2.46%     
=========================================
  Files          51      51              
  Lines        4824    4840      +16     
=========================================
+ Hits          191     311     +120     
+ Misses       4633    4529     -104     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisRackauckas
Copy link
Member

Looks like there's still an ambiguity?

@devmotion
Copy link
Contributor Author

That's unrelated AFAICT (and not intended to be fixed by the PR). I opened JuliaSymbolics/SymbolicUtils.jl#690 because I thought it was caused by SymbolicUtils. Maybe something has to be defined in Symbolics instead...

@devmotion devmotion closed this Jan 15, 2025
@devmotion devmotion reopened this Jan 15, 2025
@devmotion
Copy link
Contributor Author

This PR should be ready for review. The remaining test failures are the same as on the master branch, and seem unrelated.

@ChrisRackauckas ChrisRackauckas merged commit 269409e into JuliaSymbolics:master Jan 21, 2025
9 of 12 checks passed
@devmotion devmotion deleted the dw/pow_forwarddiff branch January 21, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NaNMath.pow derivative throws DomainError
3 participants