Allow filtering by company ID only #855
Open
+158
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twyatt
changed the title
twyatt
force-pushed
the
twyatt/companyId-only-filter
branch
from
6110574 to
bfc026e
Compare
Phoenix7351
reviewed
Feb 6, 2025
| @@ -103,7 +103,8 @@ public sealed class Filter { | |||
| */ | |||
| public val id: Int, | |||
|
|
|||
| public val data: ByteArray, | |||
| /** Must be non-`null` if [dataMask] is non-`null`. */ | |||
There was a problem hiding this comment.
Good point. Gonna check to make sure Topaz's decode covers this.
There was a problem hiding this comment.
Wasn't covered. Will add.
There was a problem hiding this comment.
Do we have this for serviceData too?
There was a problem hiding this comment.
Kable doesn't (yet) support service data filtering. 🙈
When I do get around to implementing it, then yes, it looks like it would need similar treatment.
Phoenix7351
approved these changes
Feb 6, 2025
cedrickcooke
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #854
Updated scan filtering documentation, rendered markdown here.