Skip to content
This repository has been archived by the owner on Aug 15, 2021. It is now read-only.

Breaking change incoming: InButton becoming obsolete and removing ENT:WasKeyPressed #3

Open
Jvs34 opened this issue Apr 25, 2016 · 3 comments

Comments

@Jvs34
Copy link
Owner

Jvs34 commented Apr 25, 2016

With the PlayerButtonDown/Up hooks now behaving properly during prediction clientside, there's no more use of the SetInButton/HandleButtonBind hack I had to do to set the button as active during a StartCommand message.

This means that entities will now listen to the button press in a less "hacky" way and will not clutter the cusercmd with keys you don't want to force pressed or whatever.

As with the change mentioned above, WasKeyPressed is getting removed, it was an utility function and it's functionality was questionable due to it being related to CMoveData, however it MIGHT return.

@Jvs34
Copy link
Owner Author

Jvs34 commented Apr 25, 2016

If you still need to use WasKeyPressed and IsKeyDown for the CMoveData, I'd suggest calling them directly from the CMoveData of the Move hook(s) instead.

Jvs34 added a commit that referenced this issue Apr 25, 2016
@Jvs34
Copy link
Owner Author

Jvs34 commented Apr 25, 2016

IsKeyDown had its optional movedata argument removed, as it now calls "return self:GetKeyPressed()"

@Jvs34
Copy link
Owner Author

Jvs34 commented Apr 25, 2016

Forgot to mention that these changes are currently working for the dev branch only due to the fix to PlayerButtonUp/Down

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant