Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boot files don't show config:stats print out #2207

Open
Efratror opened this issue Dec 29, 2017 · 4 comments
Open

Boot files don't show config:stats print out #2207

Efratror opened this issue Dec 29, 2017 · 4 comments
Assignees

Comments

@Efratror
Copy link
Contributor

When a boot file end's the words "Program ended" aren't displayed (user input is possible dough) and therefore making a profile result is in possible.

@hvacengi
Copy link
Member

I'll have to look into the exact logic for the profiling (I could have sworn that I have profiled boot scripts in the past).

The "program ended" portion is just because boot files trigger a "silent" context flag. They should still terminate properly and actually leave memory. I will work on verifying that is indeed the case.

I already am working on boot script messages anyways as part of #2121, so this is a logical extension.

@hvacengi hvacengi self-assigned this Dec 29, 2017
@Efratror
Copy link
Contributor Author

I've made a false assumption about the boot files not being terminated as the should because of the absence of the "program ended" and the message about the profile result. So I thought that the profile result wasn't made but it is. Issue can be closed in my opinion.

@Dunbaratu
Copy link
Member

@hvacengi you self-assigned this, but the original reporter says it's a non-issue and a misunderstanding.

If you think there's still some aspect of this issue that should remain open, but it's different from the originally described problem, can you edit the title of the issue? Otherwise I think we should close it if it keeps the same title.

@hvacengi
Copy link
Member

hvacengi commented Jan 2, 2018

I do still want this open and assigned for the sake of making sure I address it at the same time as #2121. While there isn't an internal error, this is the same kind of issue in that we are not adequately conveying the run status to users. I think the "silent" flag has use when used only to set up some default variables on boot, but for more complicated boot scripts it is useful to know that the program ended.

I would also like to configure it so that there is a way to get the config:stat print out to run from within boot scripts, even if only for the sake of our testing purposes. I find it useful when writing scripts to see things like "max update time" or "max instructions per update".

What I'm thinking is that we modify the context tracking to monitor for "IsBootScript" and then print out

Boot program ended

(using the word "program" for the sake of consistency). And that if you set config:stat to true within a boot script (or a sub-program) then "silent" is disabled, allowing the statistics to be displayed. How would you feel about that?

@Efratror Efratror changed the title Boot files aren't terminated properly Boot files don't show config:stats print out Jan 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants