Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Separate images for mod thumbnail and banner #291

Open
mwerle opened this issue Jun 25, 2020 · 6 comments
Open

[Feature] Separate images for mod thumbnail and banner #291

mwerle opened this issue Jun 25, 2020 · 6 comments
Labels
Area: Frontend Related to HTML, JS, CSS, or other browser things Priority: Normal Type: Feature

Comments

@mwerle
Copy link

mwerle commented Jun 25, 2020

Currently only a banner image can be uploaded, which is also used for the Thumbnail.

Generally if uploading a file which looks nice as the Thumbnail it looks bad as the banner, and vice versa. Furthermore, there's no information what size/ration the images should be to look good.

So:

  1. Separate images (default to current system if someone only uploads a single image)
  2. Provide clear information what a "good" image size should be
  3. Prevent the banner from tiling if a suitably-sized/ratio'd banner is uploaded
    3a) Maybe add a per-mod option to tile/scale/centre the banner? Some people might like the tiling and have uploaded a suitable image.
@HebaruSan HebaruSan added Priority: Normal Type: Feature Area: Frontend Related to HTML, JS, CSS, or other browser things labels Jun 25, 2020
@HebaruSan
Copy link
Contributor

Possibly related to #156.

@DasSkelett
Copy link
Member

I have an old branch lying around that solves this by changing the banner to a smaller image to the left of all the links and license/version/... infos, with the same aspect ration as the thumbnails.
There was some smaller issue I had with it and I got carried away by more important bugs, but I should try to rebase it and give it another try.

@DasSkelett
Copy link
Member

DasSkelett commented Jun 25, 2020

This is how it looks right now in my branch. I think the thing I still had to change was to vertically center the links & co to match the icons.

grafik

@mwerle
Copy link
Author

mwerle commented Jun 25, 2020

Suggestion along with this: Instead of listing (potentially very long) URLs next to the icons, recognise the target like you do with "Forum Thread" for the website (ie, GitHub). If the target is unkown just say "Repository" or something.

Then it can still be in 2 columns as at present and not waste so much vertical space.
Overall the image still seems to use a lot of space though.

How about using the thumbnail image/size on the mod details page as well? And having a separate "Gallery"page where people can upload a couple of images to showcase their mod? Or would that blow out hosting size too much? Might need to restrict number/size of images and deep-linking, or people will use it instead of imgur!

Eh, I'm old-skool, and an engineer to boot. I prefer information to design/layout so maybe not the best person to contribute to this conversation ;)

@Xinayder
Copy link

My suggestion is to add separate fields for mod images and banner. We should specify the max dimensions and ratio, and we could also offer a new field for mod authors to upload screenshots or images for their mod, and just replace the image with a carousel or something similar (kinda like Steam does).

@HebaruSan
Copy link
Contributor

HebaruSan commented Jun 26, 2020

Also possibly related to #165 and #224.

@HebaruSan HebaruSan changed the title (Feature Request) Separate images for mod thumbnail and banner [Feature] Separate images for mod thumbnail and banner Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Related to HTML, JS, CSS, or other browser things Priority: Normal Type: Feature
Projects
None yet
Development

No branches or pull requests

4 participants