-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When was skippatches removed? #45
Comments
I suspect you were using a fork, I don't think this project has ever had
that functionality (it did have something similar but that functionality
doesn't work now that galaxy installers have been removed).
GOG doesn't actually clearly distinguish patches from other installers in
a machine readable fashion (it's sorta doable with some pattern matching
and heuristics) so I've been leery to implement it in the past but I think
I'm gonna have to bite that bullet.
…On Tue, 29 Jun 2021, 05:35 Scosh, ***@***.***> wrote:
I recently updated from an older version of your script, and when I tried
to run it today with my typical py -2 gogrepoc.py download -skipgalaxy
-skippatches -lang en -os windows mac I got the unrecognized argument
message. Sure enough, searching through the python script, it has been
removed. The old version (I don't remember which one, but I have the file
downloaded) included it. Is there another way to accomplish the same thing?
Why was skippatches removed?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#45>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABKZ33ZXUNGSO5HTZKC7E7LTVDFGLANCNFSM47OTCZOQ>
.
|
That is SUPER weird. Because I looked in the header of the file and the only info is this:
I looked at all the current forks off of your project and can't seem to find which one it was. Oh, well. Sorry for the confusion! |
I would ask for this functionality, the amount of wasted space because of patches is enormous, i just measured my collection, around 112GB was just patch files. Cyberpunk alone has > 15GB patch files. At least for windows patches it should be quite possible, all files appear to start with "patch_" and end with ".exe" (or ".bin" additionally for really big patches, like Cyberpunk). If you would consider merging this i would be more than happy to provide a PR. // edit: I created PR #47 for an initial version. works pretty well on my setup. |
-skipfiles does this just fine and already exists. |
I recently updated from an older version of your script, and when I tried to run it today with my typical
py -2 gogrepoc.py download -skipgalaxy -skippatches -lang en -os windows mac
I got the unrecognized argument message. Sure enough, searching through the python script, it has been removed. The old version (I don't remember which one, but I have the file downloaded) included it. Is there another way to accomplish the same thing? Why was skippatches removed?The text was updated successfully, but these errors were encountered: