composeRoot not found error in case of cancelled compose with at least one recipient

[kinkoazc]

When closing a compose modal, after having added at least one recipient, an error of Can't find composeRoot for [object Object] is logged in the recipient_change event handler:

gmail.js/src/gmail.js

Line 2529 in edd1bee

if (composeRoot.length === 0) {

[josteink]

I'm not sure I fully understand the scope of this bug.

From a API usage point of view, are there use-cases which does not work as expected?

[kinkoazc]

I think that, in the described use case, it is expected that no composeRoot will be found, so I don't see the point of throwing an error, making you wonder if something is indeed not ok in/with your code.

[josteink]

In that case, I guess "error" is more severe than it needs to be. But it could be because of something unexpected happening too.

How about warning instead of error?

[kinkoazc]

Yes, that is a good idea. But only for the cases other than compose close(not sure how this case can be identified among the others, but this would be the ideal behavior).

[josteink]

Feel free to give it a try. PRs welcome 🙂