Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create custom settings #3

Open
KeizerDev opened this issue Apr 25, 2016 · 5 comments
Open

Create custom settings #3

KeizerDev opened this issue Apr 25, 2016 · 5 comments

Comments

@KeizerDev
Copy link
Owner

KeizerDev commented Apr 25, 2016

Port and ip settings

@fossfreedom
Copy link
Collaborator

not sure what this is ... but if its referring to obtaining from the user graphically their IP address and port number then this is being done under #2

@KeizerDev
Copy link
Owner Author

Yes, actually this should be ip/port/default chromecast(I'm not sure if default chromecast is a good option but yeah) and #2 should be a list of the available chromecasts in a network (pychromecast.get_chromecasts_as_dict().keys())

@fossfreedom
Copy link
Collaborator

ok - chromecast preferences dialog created - see the preferences branch

you'll need to install the schema

sudo cp schema/org* /usr/share/glib-2.0/schemas 
sudo glib-compile-schemas /usr/share/glib-2.0/schemas

Since your main module is "Chromecast.py" - with a capital "C" - the ~/.local/share/rhythmbox/plugins folder must be called "Chromecast" not "chromecast" otherwise the preferences dialog will not work.

You'll see that I've used threading to prevent the GUI freezing when connecting to chromecast.

The "Prefs.py" is no longer used - I've just renamed it for the moment.

@KeizerDev
Copy link
Owner Author

Great work! I do like to call it chromecast rather than Chromecast. Can you refactor that for me or is it as easy as just renaming the main file?

The GUI is starting normally but I still think that you should give an indactor of the extension and just list the Chromecast on the main screen and toggle the connection there. In perfect situation we should make a list button next to the player and do it like all Android apps do to toggle the connection.

After a while rhythmbox still freezes but yeah, we are getting closer.

@fossfreedom
Copy link
Collaborator

quite correct - just need to rename the main module from Chromecast.py to chromecast.py (and change the .plugin module name to match)

You can't add the chromecast icon in the toolbar - but you could add it I suppose to the sidebar.

For the moment I would suggest a button just be added to the sidebar which should allow you to connect or disconnect the chromecast set preferences rather than trying to connect immediately on startup.

Once the crashing is fixed then should revisit this bit to add a "chromecast" icon as you suggest above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants