Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sql.reader more flexible for odbcDriverConnect #144

Open
tomschloss opened this issue Mar 11, 2016 · 3 comments
Open

Make sql.reader more flexible for odbcDriverConnect #144

tomschloss opened this issue Mar 11, 2016 · 3 comments
Labels

Comments

@tomschloss
Copy link

This is more of a selfish feature request which I'm happy to work on, but wondering if you have any concerns with the idea.

The current sql.reader for odbc requires very particular inputs. odbcDriverConnect accepts a whole bunch of other inputs by allowing "a more flexible specification via a connection string". My idea is for sql.reader to be a little more flexible with inputs to make use of this flexibility. Basically, instead of looking only at specified settings (dsn; user; password; dbname) it would pull through all the settings specified.

@KentonWhite
Copy link
Owner

I like the idea. I've been bit a few times with sql.reader not accepting all of the inputs and have made piecemeal changes when they come up (e.g. passing a port to postgres). Really appreciate your offer to look into a more flexible specification. Please be considerate of others and use sensible defaults when a setting is missing.

@tomschloss
Copy link
Author

Hopefully this is on point. Let me know either way. I think there is some possibility for extending this to the other db connection types.

@KentonWhite
Copy link
Owner

Bumping this as it is a good idea. Anyone with expertise that can work on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants