Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebRequestInterceptResult.Reject gives unwanted stop for other urls too. #184

Closed
AttilaBarany opened this issue Jun 26, 2024 · 3 comments · Fixed by #185
Closed

WebRequestInterceptResult.Reject gives unwanted stop for other urls too. #184

AttilaBarany opened this issue Jun 26, 2024 · 3 comments · Fixed by #185
Assignees
Labels
enhancement New feature or request

Comments

@AttilaBarany
Copy link

Hi,

I have a problem because on android the interception reject calls webview.stopLoading() additionaly on top of returning true for shouldOverrideUrlLoading. Only return true should be enough which prevents to load that specific url. I tried with normal androidview and I am sure that stopLoading causes the problem (additional forwarding will not trigger anymore if stoploading is called before returning true). This is unwanted behaviour because we would like to intercept only one specific url at a time, but not all.

Cheers:)

Screenshot 2024-06-26 at 17 12 22
@AttilaBarany
Copy link
Author

Of course stoploading is ok at modify, make sense, but not in reject.

@KevinnZou
Copy link
Owner

@AttilaBarany Thanks for your suggestion! I will add it to the plan. You are also welcome to submit a PR to fix it!

@KevinnZou KevinnZou self-assigned this Jun 26, 2024
@KevinnZou KevinnZou added the enhancement New feature or request label Jun 26, 2024
@AttilaBarany
Copy link
Author

@AttilaBarany Thanks for your suggestion! I will add it to the plan. You are also welcome to submit a PR to fix it!

Thanks for the chance. (#185)

KevinnZou added a commit that referenced this issue Jun 29, 2024
Fixing sideeffect of interceptresult reject on Android #184
@KevinnZou KevinnZou linked a pull request Jun 29, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants