Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧Update OpenAL #146

Conversation

CalvinWilkinson
Copy link
Member

Preview Feature Pull Request

📋Review Checklist📋

  • The head(source) branch for this pull request is a preview feature branch, with the correct naming syntax, in the following example:

    • A head(source) branch is the branch being merged into a target branch.

      Example
      Syntax: preview/feature/<issue-num>-<description>
      Example: preview/feature/123-my-preview-feature
  • The head(source) branch for this pull request is created from a preview release branch, with the correct naming syntax, in the following example:

    Example
    Syntax: preview/v<major>.<minor>.<patch>-preview.<prev-num>
    Example: preview/v1.2.3-preview.4
  • The base(target) branch for this pull request is a preview release branch, with the correct naming syntax, in the following example:

    • A base(target) branch is the branch that the head(source) branch is merging into.

      Example
      Syntax: preview/v<major>.<minor>.<patch>-preview.<prev-num>
      Example: preview/v1.2.3-preview.4

💡For more information on branching, refer to the project's branching documentation.

  • Associated issue exists and is linked to this pull request.

    • One issue per pull request.
  • Pull request title matches the title of the associated issue.

  • A preview label has been added to the pull request.

  • The labels attached to this PR match the labels attached to the associated issue.

  • Project assigned matches the project of the associated issue.

  • Milestone assigned matches the milestone of the associated issue.

  • My code follows the coding style of this project.

    • The style is enforced by the .editorconfig files in the project and displayed as warnings. If there is an edge case, reach out, and let's discuss it.
  • I have manually tested my code changes to the best of my ability.

  • All tests passed locally.

    • This is required because unit tests might pass locally but not in the CI environment during the status check process or vice-versa.
    • Tests might pass on the developer's machine but not necessarily on the code reviewer's machine.
    • Status checks run for this pull request when merging into the preview/v*.*.*-preview.* branch. These status checks run every time a change is pushed to the pull request. These checks validate version syntax, tagging, builds, unit tests, and more.

@CalvinWilkinson CalvinWilkinson self-assigned this Feb 11, 2023
@CalvinWilkinson CalvinWilkinson added 📦dependency-update Dependency update with required code changes high-priority High Priority preview Done while in preview labels Feb 11, 2023
@CalvinWilkinson CalvinWilkinson linked an issue Feb 11, 2023 that may be closed by this pull request
12 tasks
@CalvinWilkinson CalvinWilkinson deleted the preview/feature/102-update-openal branch June 10, 2023 16:19
@CalvinWilkinson CalvinWilkinson removed a link to an issue Jan 27, 2025
12 tasks
@CalvinWilkinson
Copy link
Member Author

pr closed without merging.

Reason:
This pr is very old and things have changed. PR recreated to get up to date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦dependency-update Dependency update with required code changes high-priority High Priority preview Done while in preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant