Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

49 Matches with "Failed to open nested jar" #46

Open
ghost opened this issue Jul 30, 2023 · 3 comments
Open

49 Matches with "Failed to open nested jar" #46

ghost opened this issue Jul 30, 2023 · 3 comments
Labels
bug Something isn't working high-priority This issue is very important lljzip Issue is caused by LL-Java-Zip

Comments

@ghost
Copy link

ghost commented Jul 30, 2023

Hello there, i'm using jneedle 1.0.1 fat on Debian. Did a scan using java -jar jneedle-1.0.1-fat.jar -f /home/ --threads 32 (as root) and application returned

Finished running, checked 6433, found 49
Malware checking done in 39546 ms

When i check the output it's all "(Failed to open nested jar)"

/home/ozone/mods/EnderIO-1.12.2-5.2.66.jar matches [INFO(Failed to open nested jar: java.nio.ByteBuffer.position(I)Ljava/nio/ByteBuffer;)]
/home/rktfier/minecraft-server/.retired/aprilfools/mods/NoChatReports-FABRIC-1.19.4-v2.1.1.jar matches [INFO(Failed to open nested jar: java.nio.ByteBuffer.position(I)Ljava/nio/ByteBuffer;)]
/home/dannydebes/uploadspace/new-server/cache/mojang_1.20.1.jar matches [INFO(Failed to open nested jar: java.nio.ByteBuffer.position(I)Ljava/nio/ByteBuffer;)]

Are these false-positives caused by something or are we screwed?

@KosmX KosmX added bug Something isn't working high-priority This issue is very important labels Jul 30, 2023
@KosmX
Copy link
Owner

KosmX commented Jul 30, 2023

Yes, nested jar errors are counted as matches.
The issue is with the used LLJzip library and java 1.8. It will be fixed very soon

@KosmX
Copy link
Owner

KosmX commented Jul 31, 2023

There is a new pre-release release, can you try that?
https://github.com/KosmX/jneedle/releases/tag/1.1.0-local

@ghost
Copy link
Author

ghost commented Jul 31, 2023

I have downloaded the CLI version for the server. I get the following error :

08:03:30.823 [DefaultDispatcher-worker-32] DEBUG dev.kosmx.needle.scanner.JarScanner -- Start scanning nested jar: META-INF/licenses/saslprep-1.1.jar/
08:03:30.823 [DefaultDispatcher-worker-32] INFO dev.kosmx.needle.scanner.JarScanner -- Not enough bytes to read Central-Directory-File-Header, minimum=22
java.io.IOException: Not enough bytes to read Central-Directory-File-Header, minimum=22
        at software.coley.lljzip.ZipIO.read(ZipIO.java:223)
        at software.coley.lljzip.ZipIO.readJvm(ZipIO.java:134)
        at dev.kosmx.needle.scanner.JarScanner.checkJar(JarScanner.kt:38)
        at dev.kosmx.needle.scanner.ScanConfig.checkJar(ScanConfig.kt:62)
        at dev.kosmx.needle.scanner.ScanConfig$checkPath$3$4.invokeSuspend(ScanConfig.kt:144)
        at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
        at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:108)
        at kotlinx.coroutines.internal.LimitedDispatcher$Worker.run(LimitedDispatcher.kt:115)
        at kotlinx.coroutines.scheduling.TaskImpl.run(Tasks.kt:103)
        at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:584)
        at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:793)
        at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:697)
        at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:684)

It repeats a lot but the app reports

Finished running, checked 6434, found 0
Malware checking done in 49672 ms

@KosmX KosmX added the lljzip Issue is caused by LL-Java-Zip label Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high-priority This issue is very important lljzip Issue is caused by LL-Java-Zip
Projects
None yet
Development

No branches or pull requests

1 participant