Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Obsolete]: Remove SetTheme method from ThemeManager #2022

Open
giduac opened this issue Dec 30, 2024 · 2 comments
Open

[Obsolete]: Remove SetTheme method from ThemeManager #2022

giduac opened this issue Dec 30, 2024 · 2 comments
Labels
bug Something isn't working obsolete version:100 All things to do with V100.
Milestone

Comments

@giduac
Copy link
Contributor

giduac commented Dec 30, 2024

Describe the bug
In ThemeManager the method SetTheme is obsolete and has to be removed in V100

        /// <summary>
        /// Sets the theme.
        /// </summary>
        /// <param name="themeName">Name of the theme.</param>
        /// <param name="manager">The manager.</param>
        [Obsolete("Deprecated and will be removed in V100. Replace this with calls to ApplyTheme( . . . )")]
        public static void SetTheme(string themeName, KryptonManager manager) =>
            //TODO V100 Remove SetTheme method
            ApplyGlobalTheme(manager, GetThemeManagerMode(themeName));
@giduac giduac added bug Something isn't working version:100 All things to do with V100. labels Dec 30, 2024
@giduac giduac added this to the Version 100 milestone Dec 30, 2024
@Smurf-IV
Copy link
Member

Note: Please check all the other instances of the Obsolete usage in the alpha branch as well.

@giduac
Copy link
Contributor Author

giduac commented Jan 12, 2025

Note: Please check all the other instances of the Obsolete usage in the alpha branch as well.
@Smurf-IV , @PWagner1 && @Ahmed-Abdelhameed

Please have a look the search results for 'Obsolete' and respond with what can be taken out.
After that this call can be altered to take them out all at once.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working obsolete version:100 All things to do with V100.
Projects
None yet
Development

No branches or pull requests

2 participants