Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve opj handler returned errors #310

Merged
merged 5 commits into from
Feb 6, 2025

Conversation

ColdsteelRail
Copy link
Member

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 86.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 66.15%. Comparing base (70ed38b) to head (8df874f).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ontrollers/operationjob/operationjob_controller.go 0.00% 2 Missing and 1 partial ⚠️
...g/controllers/operationjob/operationjob_manager.go 96.29% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #310      +/-   ##
==========================================
- Coverage   66.18%   66.15%   -0.03%     
==========================================
  Files          79       79              
  Lines        5764     5780      +16     
==========================================
+ Hits         3815     3824       +9     
- Misses       1590     1595       +5     
- Partials      359      361       +2     
Flag Coverage Δ
unittests 66.15% <86.66%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ColdsteelRail ColdsteelRail merged commit 6b9b766 into main Feb 6, 2025
11 of 12 checks passed
@ColdsteelRail ColdsteelRail deleted the opj-release-target-when-failed branch February 6, 2025 06:52
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

提供灰度流量的能力
2 participants