Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support multi cluster #32

Merged
merged 2 commits into from
Jan 31, 2024
Merged

feat: support multi cluster #32

merged 2 commits into from
Jan 31, 2024

Conversation

WeichengWang1
Copy link
Collaborator

@WeichengWang1 WeichengWang1 commented Jan 31, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

re #30

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@WeichengWang1 WeichengWang1 self-assigned this Jan 31, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2024

Codecov Report

Attention: 148 lines in your changes are missing coverage. Please review.

Comparison is base (8169452) 64.49% compared to head (1154b20) 59.07%.

Files Patch % Lines
pkg/frame/controller/consister.go 37.12% 101 Missing and 26 partials ⚠️
pkg/frame/controller/resourceconsist_controller.go 55.31% 16 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
- Coverage   64.49%   59.07%   -5.43%     
==========================================
  Files           4        4              
  Lines         907     1085     +178     
==========================================
+ Hits          585      641      +56     
- Misses        247      344      +97     
- Partials       75      100      +25     
Flag Coverage Δ
unittests 59.07% <40.56%> (-5.43%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WeichengWang1 WeichengWang1 merged commit 62b7587 into main Jan 31, 2024
5 checks passed
@WeichengWang1 WeichengWang1 deleted the multiCluster branch January 31, 2024 02:35
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants