You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Lens currently has multiple responsibilities, including constructing transient point sources using provided kwargs and strings, leading to shared responsibilities with other components.
Proposed Solution
Use the dependency injection design pattern and refactor Lens to take two Galaxy objects as inputs (see #227 ), representing the deflector and source galaxy. The source Galaxy object has full responsibility for providing any related point sources. The Lens class's responsibility is to handle any strong lensing interaction between the provided Galaxy objects.
To-Do List
TBD
The text was updated successfully, but these errors were encountered:
Current Status
Lens
currently has multiple responsibilities, including constructing transient point sources using provided kwargs and strings, leading to shared responsibilities with other components.Proposed Solution
Use the dependency injection design pattern and refactor
Lens
to take twoGalaxy
objects as inputs (see #227 ), representing the deflector and source galaxy. The sourceGalaxy
object has full responsibility for providing any related point sources. TheLens
class's responsibility is to handle any strong lensing interaction between the providedGalaxy
objects.To-Do List
The text was updated successfully, but these errors were encountered: