Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring SLSim - Refactor Lens class #228

Open
1 task
jacob-hjortlund opened this issue Aug 6, 2024 · 0 comments
Open
1 task

Refactoring SLSim - Refactor Lens class #228

jacob-hjortlund opened this issue Aug 6, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@jacob-hjortlund
Copy link
Collaborator

Current Status

Lens currently has multiple responsibilities, including constructing transient point sources using provided kwargs and strings, leading to shared responsibilities with other components.

Proposed Solution

Use the dependency injection design pattern and refactor Lens to take two Galaxy objects as inputs (see #227 ), representing the deflector and source galaxy. The source Galaxy object has full responsibility for providing any related point sources. The Lens class's responsibility is to handle any strong lensing interaction between the provided Galaxy objects.

To-Do List

  • TBD
@jacob-hjortlund jacob-hjortlund self-assigned this Aug 6, 2024
@jacob-hjortlund jacob-hjortlund added the enhancement New feature or request label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant