Temporal Helm Chart Target Type

[tjsampson]

I tried installing the chart with autoscaling and the HPA failed. Pretty sure you need to update the hpa.yaml template metrics to look like this:

  metrics:
  {{- if $serviceValues.autoscaling.targetCPUUtilizationPercentage }}
    - type: Resource
      resource:
        name: cpu
        target:
          type: Utilization
          averageUtilization: {{ $serviceValues.autoscaling.targetCPUUtilizationPercentage }}
  {{- end }}
  {{- if $serviceValues.autoscaling.targetMemoryUtilizationPercentage }}
    - type: Resource
      resource:
        name: memory
        target:
          type: Utilization
          averageUtilization: {{ $serviceValues.autoscaling.targetMemoryUtilizationPercentage }}
  {{- end }}

Instead of this:

  metrics:
  {{- if $serviceValues.autoscaling.targetCPUUtilizationPercentage }}
    - type: Resource
      resource:
        name: cpu
        targetAverageUtilization: {{ $serviceValues.autoscaling.targetCPUUtilizationPercentage }}
  {{- end }}
  {{- if $serviceValues.autoscaling.targetMemoryUtilizationPercentage }}
    - type: Resource
      resource:
        name: memory
        targetAverageUtilization: {{ $serviceValues.autoscaling.targetMemoryUtilizationPercentage }}
  {{- end }}

Here is an example from the kubernets docs: https://kubernetes.io/docs/tasks/run-application/horizontal-pod-autoscale-walkthrough/#autoscaling-on-multiple-metrics-and-custom-metrics

  metrics:
  - type: Resource
    resource:
      name: cpu
      target:
        type: Utilization
        averageUtilization: 50