Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up warnings and rust-like code #8

Open
ClementLokad opened this issue May 7, 2024 · 0 comments
Open

Clean up warnings and rust-like code #8

ClementLokad opened this issue May 7, 2024 · 0 comments
Assignees
@EslaMx7
Labels
enhancement New feature or request

Comments

@ClementLokad
Copy link
Collaborator

Hello,

A last enhancement issue, could you make a pass on the warnings (add some constructors, remove some async keywords for example) and rename some variables https://github.com/Lokad/Tokenizers/blob/master/src/Lokad.Tokenizers/Tokenizer/BaseTokenizer.cs#L711 to respect the dotnet conventions) please?
@ClementLokad ClementLokad mentioned this issue May 14, 2024
Open
@EslaMx7 EslaMx7 added the enhancement New feature or request label May 14, 2024
@EslaMx7 EslaMx7 self-assigned this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EslaMx7 EslaMx7

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@EslaMx7 @ClementLokad