Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DLCModelSource uses fetch1 when restricting by a secondary key #1105

Closed
CBroz1 opened this issue Sep 11, 2024 · 0 comments · Fixed by #1192
Closed

DLCModelSource uses fetch1 when restricting by a secondary key #1105

CBroz1 opened this issue Sep 11, 2024 · 0 comments · Fixed by #1192
Assignees
Labels
bug Something isn't working position

Comments

@CBroz1
Copy link
Member

CBroz1 commented Sep 11, 2024

This portion of position_dlc_model

  1. Uses a FreeTable to fetch a dependency
  2. Presumes uniqueness of project_name that is not enforced by the DLCModelTraining table

table_query = dj.FreeTable(
dj.conn(), full_table_name=part_table.parents()[-1]
) & {"project_name": project_name}
project_path = table_query.fetch1("project_path")

These should be removed in favor if restricting by the primary key of the parent, used directly

@CBroz1 CBroz1 self-assigned this Sep 11, 2024
@CBroz1 CBroz1 added bug Something isn't working position labels Sep 11, 2024
CBroz1 added a commit to CBroz1/spyglass that referenced this issue Nov 21, 2024
@CBroz1 CBroz1 linked a pull request Nov 21, 2024 that will close this issue
7 tasks
@CBroz1 CBroz1 mentioned this issue Nov 27, 2024
7 tasks
edeno pushed a commit that referenced this issue Dec 5, 2024
* #1175

* #1185

* #1183

* Fix circular import

* #1163

* #1105

* Fix failing tests, close download subprocesses

* WIP: fix decode changes spikesort tests

* Fix fickle test

* Revert typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working position
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant