Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fetch_nwb assumes fetching table inherits Mixin #1200

Closed
sytseng opened this issue Dec 13, 2024 · 0 comments · Fixed by #1201
Closed

fetch_nwb assumes fetching table inherits Mixin #1200

sytseng opened this issue Dec 13, 2024 · 0 comments · Fixed by #1201
Assignees
@CBroz1 @samuelbray32

Comments

@sytseng
Copy link

sytseng commented Dec 13, 2024

Related to #1185, the same lines of code still exist in fetch_nwb function (lines 304-306):

query_table = query_expression.join(
    tbl.proj(nwb2load_filepath=attr_name), log_export=False
)

And it throws an error when calling this function on tables not inherited from Mixin. Can the same changes in get_nwb_table (line 238-250) be applied here as well?
@CBroz1 CBroz1 self-assigned this Dec 16, 2024
@samuelbray32 samuelbray32 self-assigned this Dec 17, 2024
@samuelbray32 samuelbray32 mentioned this issue Dec 17, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CBroz1 CBroz1

@samuelbray32 samuelbray32

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fetch_nwb non-mixin compatability LorenFrankLab/spyglass
3 participants
@CBroz1 @samuelbray32 @sytseng