Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adaptors should **not** change the dtype #462

Closed
YichengDWu opened this issue Nov 25, 2023 · 1 comment
Closed

Adaptors should **not** change the dtype #462

YichengDWu opened this issue Nov 25, 2023 · 1 comment

Comments

@YichengDWu
Copy link
Contributor

The following definition would change x of dtype Float64 to Float32.

adapt_storage(::LuxCUDAAdaptor, x) = cu(x)
@avik-pal
Copy link
Member

Yes, this is expected. For 99% of users, moving data from CPU to GPU would want it to be Float32 (or whatever is the best choice for that accelerator). The remaining 1% definitely know what they are doing and can make the data Float64 using |> f64.

@avik-pal avik-pal closed this as not planned Won't fix, can't repro, duplicate, stale Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@avik-pal @YichengDWu