Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Game resolution is lowered when exiting / entering the menu. #30

Open
laur33 opened this issue Feb 23, 2024 · 6 comments
Open

Game resolution is lowered when exiting / entering the menu. #30

laur33 opened this issue Feb 23, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@laur33
Copy link

laur33 commented Feb 23, 2024

Issue Summary:

For a short time before and after entering the menu the in game resolution seems to get lowered. This lower resolution is also visible in the background of the menu.

Seems related to #26 though concerning the in game resolution rather then the menu resolution.

P3RFix & Game Version Numbers:

1.1.4

Log Files:

P3RFix.log

Reproduction:

Issue is visible when entering and exiting the menu.

Heres are two screenshots (uploaded to mega due to size...), one during normal gameplay with expected resolution. The other lower resolution image is right after exiting the menu (before the UI displays again). The lower resolution is easier to see around character models when zoomed in.

https://mega.nz/file/PFIDRDqK#coAbEgGe3PjlXJNq6ieBWHpdbwaubq4m8NjXhyRrAMY

Background static image keeps this lower resolution frame in the menu (look around mitsuru for clear aliasing introduced by this).

Photos 23_02_2024 8_30_10 PM

@laur33 laur33 added the bug Something isn't working label Feb 23, 2024
@Lyall
Copy link
Owner

Lyall commented Feb 23, 2024

Hmm it seems like it is maybe an issue in the vanilla game with no mods installed. You'll have to forgive me for the black bars but here's a comparison.

https://imgsli.com/MjQyMDAy/0/1

Edit: These are at 1440p with 200% render scale in the settings, (which is actually 133.33%~ screen percentage 😠). The differences would probably be more noticeable at a higher resolution like the one you're using.

@Lyall
Copy link
Owner

Lyall commented Feb 23, 2024

Can you try this test build? I've modified the RT_Capture render texture so that it's always set to your screen resolution * screen percentage.

Looking at it on my end there's still some kind of blur as you leave the menu but I can't tell if it's from actually running at a lower resolution or simply something like a guassian blur post-process.

@laur33
Copy link
Author

laur33 commented Feb 24, 2024

Hmm it seems the same on my side between 1.1.4 and that test build.

Heres a comparison on only the new fix, normal res vs lower res.
https://imgsli.com/MjQyMTU4

Heres a comparison between 1.1.4 and the new fix lower resolutions. (No visible change)
https://imgsli.com/MjQyMTYw

I think it is a resolution issue because of the stair stepped aliasing that is introduced like below.
image

New fix log
P3RFix.log

@Lyall
Copy link
Owner

Lyall commented Feb 24, 2024

Hmm, I think I'll need to poke around in Nsight or something to get some answers as to what we're actually looking at.

@Lyall
Copy link
Owner

Lyall commented Feb 24, 2024

Okay here's some captures straight from Nsight. I've uploaded them to a comparison site that doesn't compress the files.

https://slow.pics/c/Z1GbBMGe

So the first picture is after exiting the menu, then the second one is the next step in rendering the image. Then the third is a shot from in-game for a reference image to compare to.

To me it looks like some kind of blur is being applied, there's also noticeable artifacts like the colour banding in the top right. I'm not exactly well versed at following along in an Nsight capture but it looks to me like the blurring is causing it look lower res than it actually is.

@laur33
Copy link
Author

laur33 commented Feb 24, 2024

Ah interesting I didn't notice that colour banding it does make it seem like a filter effect. I wonder why the pixelation seems much more pronounced in my screens.

I've tried increasing render scale to 200% aswell and the pixelation is still the same. Is it possible to add an option to disable this filter?

https://imgsli.com/MjQyMTg4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants