Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug in pwr_spec #231

Open
ericthewizard opened this issue Dec 16, 2024 · 3 comments
Open

bug in pwr_spec #231

ericthewizard opened this issue Dec 16, 2024 · 3 comments
Assignees

Comments

@ericthewizard
Copy link
Collaborator

It looks like the "name" keyword was updated to "newname", but the references to "name" in the function weren't updated:

https://github.com/MAVENSDC/PyTplot/blob/matplotlib-backend/pytplot/tplot_math/pwr_spec.py

@ericthewizard
Copy link
Collaborator Author

Another issue I noticed: there isn't a check for whether the tplot variable actually exists in this function, so it crashes when you give it a variable name that doesn't exist:

    x, y = d[0], d[1]
           ~^^^
TypeError: 'NoneType' object is not subscriptable

@xandrd
Copy link
Collaborator

xandrd commented Dec 17, 2024

@jameswilburlewis, since the plan it to "fork" tplot into pyspedas, let make sure that we fix this before.

@jameswilburlewis
Copy link
Collaborator

Thanks for letting us know! Should be an easy fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants