Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STL immersed boundaries don't work with an applied rotation #787

Closed
wilfonba opened this issue Jan 4, 2025 · 3 comments · Fixed by #788
Closed

STL immersed boundaries don't work with an applied rotation #787

wilfonba opened this issue Jan 4, 2025 · 3 comments · Fixed by #788
Assignees
Labels
bug Something isn't working or doesn't seem right

Comments

@wilfonba
Copy link
Contributor

wilfonba commented Jan 4, 2025

STL immersed boundaries don't appear to be working with rotations. The attached case file and STL produce the following output:
image
The expected output is achieved when the rotation is removed from the case file and is shown below:
image
Both figures show the ib_markers variable at the vertical centerline of the domain. This is likely a problem with STL patches as well, but I haven't tested that yet.
bugReport.zip

@wilfonba wilfonba added the bug Something isn't working or doesn't seem right label Jan 4, 2025
@sbryngelson
Copy link
Member

thanks for identifying this @wilfonba

@haochey
Copy link
Contributor

haochey commented Jan 7, 2025

I can replicate this problem with STL patches. It seems to be an issue with the transform matrix in the function f_create_transform_matrix in m_helper.fpp. I spent some time on debugging this but haven't fixed it. I will continue when I find some time.

@sbryngelson sbryngelson linked a pull request Jan 10, 2025 that will close this issue
9 tasks
@sbryngelson
Copy link
Member

closed by #788

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working or doesn't seem right
Development

Successfully merging a pull request may close this issue.

3 participants