Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code redundancy in GRUD forward method #58

Open
2533245542 opened this issue Oct 13, 2021 · 1 comment
Open

code redundancy in GRUD forward method #58

2533245542 opened this issue Oct 13, 2021 · 1 comment

Comments

@2533245542
Copy link

This line of code is repeated twice. Not sure if it is just calculated twice or would have an effect on the computational graph of the model though.

self.drop(self.bn(self.fc(Hidden_State)))

MIMIC_Extract/notebooks/mmd_grud_utils.py

Line 192 in 0e83501

self.drop(self.bn(self.fc(Hidden_State)))

@2533245542
Copy link
Author

Tested. It actually makes a difference. The same operation was recorded twice in the computational graph. Should remove this line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@2533245542