Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LabelBot] Verify GitHub signature before enqueuing in SQS #27

Open
marcoabreu opened this issue Nov 7, 2018 · 0 comments
Open

[LabelBot] Verify GitHub signature before enqueuing in SQS #27

marcoabreu opened this issue Nov 7, 2018 · 0 comments

Comments

@marcoabreu
Copy link
Contributor

At the moment, we verify the signature of the webhook in the Labelbot which is the second instance. This means that an attacker could flood our SQS queue because the request is not being validated at that point.

The verification should be moved from the LabelBot lambda function to the API Gateway endpoint since that's the first time we're interacting with the message. Validating the message at this point allows decline an invalid message at the earliest point possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant