-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solution to the issue with Scheduled Installs #270
Comments
I think I'm seeing the same thing.
|
Specifically, where does 409 minutes come from? My calculation says it should be ~240 minutes.
|
I included the explanation in the original post. Its the difference between the time the script started and the time the scheduled restart was submitted. Ex: You scheduled the restart to be 4 hours ahead (240 mins) but the amount of time between the actual script starting and you scheduling the restart was 169 minutes, totaling 409 minutes. Could be a combination of the time it took the update to prepare and how long the restart dialog displayed before the schedule restart button was clicked. |
There is an issue that has been reported about Scheduled Installs not running at the date/time they are scheduled. I did some research and believe I have found the cause and solution.
in the #super script, Line 5360 , the calculation for determining the deferral_timer_scheduled_install_minutes is
workflow_scheduled_install_epoch - workflow_time_epoch) / 60
I believe the problem is that the
workflow_time_epoch
appears to get set at the beginning of the runtime, and If the update takes time to download and prepare, and/or restart dialog is displayed for a user for a long period of time because they are either away or choose to ignore it, the time between those two epoch's grows, erroneously inflating the calculation. The WorkflowScheduledInstall datetime appears correct, but the NextAutoLaunch is inflated withI added
workflow_time_epoch=$(date +%s)
above that line to set it to the current time, and that appears to calculate the proper deferral minutes.I'm doing some additional testing but so far this looks to be the problem/solution.
i've attached a verbose log with the invalid calculation, and another verbose log from after adding that fix
superLogVerbose - invalid Deferral Minutes.log
superLogVerbose - Valid Deferral Minutes.log
The text was updated successfully, but these errors were encountered: