Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work on Chrome/Thorium #18

Closed
Rosentti opened this issue Jul 30, 2024 · 1 comment
Closed

Doesn't work on Chrome/Thorium #18

Rosentti opened this issue Jul 30, 2024 · 1 comment
Assignees
Labels
bug Something isn't working fixed in dev already fixed in the repository, not yet submitted/pending submission

Comments

@Rosentti
Copy link
Contributor

Recently switched to Thorium, since it's the only browser that has working x265 decoding.
On this video, nothing is being blocked:
image
image
This checkbox also doesn't save it's state:
image
Other videos also have this problem:
image

I've copied the selector of a bit of ad text inside the description, in case it's useful:
#description-inline-expander > yt-attributed-string > span > span:nth-child(1)

@MagicJinn
Copy link
Owner

Turns out I am the dumbest guy. I did not add "permissions":["storage"] to the manifest v3 file, only to v2. The reason I did not find this during testing is because I use the manifest v2 during testing, even on Chrome. Thanks for the report, it should now be fixed!
Be aware that according to #9, some sponsors are no longer removed entirely (in the example of the video, it shortens it to Ad: Remove your personal information from the web at , which isn't ideal. I'm working on it.

@MagicJinn MagicJinn self-assigned this Jul 30, 2024
@MagicJinn MagicJinn added bug Something isn't working fixed in dev already fixed in the repository, not yet submitted/pending submission labels Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed in dev already fixed in the repository, not yet submitted/pending submission
Projects
None yet
Development

No branches or pull requests

2 participants