fix: Fix Traefik TLS verification to front #390
+53
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: fastlorenzo <[email protected]>
|
I tried this locally and it only worked when adding the following annotation to the Also, helm warns about the |
DrPsychick
suggested changes
Dec 29, 2024
| @@ -18,6 +18,9 @@ metadata: | |||
| {{- if .Values.commonAnnotations }} | |||
| {{- include "common.tplvalues.render" ( dict "value" .Values.commonAnnotations "context" $ ) | nindent 4 }} | |||
| {{- end }} | |||
| {{- if and (eq .Values.ingress.type "traefik") .Values.ingress.enabled .Values.ingress.traefik.insecureSkipVerify }} | |||
There was a problem hiding this comment.
This is needed instead on the mailu-front service. Although it's also documented for Ingress: https://doc.traefik.io/traefik-hub/api-gateway/reference/routing/kubernetes/http/services/ref-svc-annotations
Also, the https/443 port on the mailu-front deployment should be enabled again, otherwise traefik refuses to link the ingress as the pod does not expose https
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes fixing support for Traefik as an ingress controller and allowing the disabling of TLS verification between Traefik and the backend.
Documentation updates:
mailu/README.md: Added descriptions for new ingress settings, includingingress.typeandingress.traefik.insecureSkipVerify. [1] [2]Configuration updates:
mailu/values.yaml: Introduced new parametersingress.typeandingress.traefik.insecureSkipVerifyto support Traefik and allow disabling TLS verification.Template updates:
mailu/templates/front/ingress.yaml: Added conditional annotations for Traefik wheningress.traefik.insecureSkipVerifyis enabled.mailu/templates/front/service.yaml: IncludedserversTransportconfiguration for Traefik wheningress.traefik.insecureSkipVerifyis enabled.mailu/templates/front/traefik-serverstransport.yaml: Added a new template forServersTransportresource configuration when using Traefik withinsecureSkipVerify.Fixes #368