Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling pure component check #3

Open
GeKorm opened this issue Jun 5, 2017 · 0 comments
Open

Allow disabling pure component check #3

GeKorm opened this issue Jun 5, 2017 · 0 comments

Comments

@GeKorm
Copy link

GeKorm commented Jun 5, 2017

Hello, thanks for making this great package!

It would be great if there was an option to disable the 'Component is impure and will ALWAYS update when a component above it does' check.

Having every component be pure isn't optimal, since components that need to update often are going through unnecessary shouldComponentUpdate checks. More discussion here.
It's not a huge thing, but for components that are intentionally left as impure, the console warning is impossible to mute without excluding the component from other useful checks.

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant