From ac6e1825bac74ecd173431105e29ccacfb7b3ffb Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Patrik=20Kom=C3=A1nek?= <pkomanek@redhat.com>
Date: Wed, 9 Nov 2016 10:36:53 +0100
Subject: [PATCH] Refactoring the available_flavors spec for the automate Cloud
 Orchestration.

---
 .../__methods__/available_flavors.rb          |  18 +--
 .../available_flavors_spec.rb                 |  83 ------------
 .../__methods__/available_flavors_spec.rb     | 119 ++++++++++++++++++
 3 files changed, 125 insertions(+), 95 deletions(-)
 delete mode 100644 spec/automation/unit/method_validation/available_flavors_spec.rb
 create mode 100644 spec/db/fixtures/ae_datastore/ManageIQ/Cloud/Orchestration/Operations/Methods.class/__methods__/available_flavors_spec.rb

diff --git a/db/fixtures/ae_datastore/ManageIQ/Cloud/Orchestration/Operations/Methods.class/__methods__/available_flavors.rb b/db/fixtures/ae_datastore/ManageIQ/Cloud/Orchestration/Operations/Methods.class/__methods__/available_flavors.rb
index 2adc968c345..250097a77d4 100644
--- a/db/fixtures/ae_datastore/ManageIQ/Cloud/Orchestration/Operations/Methods.class/__methods__/available_flavors.rb
+++ b/db/fixtures/ae_datastore/ManageIQ/Cloud/Orchestration/Operations/Methods.class/__methods__/available_flavors.rb
@@ -12,27 +12,21 @@ def initialize(handle = $evm)
             end
 
             def main
-              fill_dialog_field(fetch_selected_os)
+              fill_dialog_field(fetch_list_data)
             end
 
-            def fetch_selected_os
-              flavor_list = {}
-              service = $evm.root.attributes["service_template"] || $evm.root.attributes["service"]
-              if service.respond_to?(:orchestration_manager) && service.orchestration_manager
-                service.orchestration_manager.flavors.each { |f| flavor_list[f.name] = f.name }
-              end
-              flavor_list[nil] = flavor_list.empty? ? "<None>" : "<Choose>"
-
+            private
 
+            def fetch_list_data
               service = @handle.root.attributes["service_template"] || @handle.root.attributes["service"]
               flavors = service.try(:orchestration_manager).try(:flavors)
 
               flavor_list = {}
-              flavor_list.each { |f| flavor_list[f.name] = f.name } if flavors
+              flavors.each { |f| flavor_list[f.name] = f.name } if flavors
 
-              return nil => "<None>" if flavor_list.blank?
+              return nil => "<none>" if flavor_list.blank?
 
-              flavor_list[nil] = "<Choose>" if flavor_list.length > 1
+              flavor_list[nil] = "<select>" if flavor_list.length > 1
               flavor_list
             end
 
diff --git a/spec/automation/unit/method_validation/available_flavors_spec.rb b/spec/automation/unit/method_validation/available_flavors_spec.rb
deleted file mode 100644
index 8d39d5f46fe..00000000000
--- a/spec/automation/unit/method_validation/available_flavors_spec.rb
+++ /dev/null
@@ -1,83 +0,0 @@
-describe "Available_Flavors Method Validation" do
-  let(:user) { FactoryGirl.create(:user_with_group) }
-  let(:default_desc) { "<None>" }
-  before do
-    @ins = "/Cloud/Orchestration/Operations/Methods/Available_Flavors"
-  end
-
-  context "workspace has no service template" do
-    it "provides only default value to the flavor list" do
-      ws = MiqAeEngine.instantiate(@ins.to_s, user)
-      expect(ws.root["values"]).to eq(nil => default_desc)
-      expect(ws.root["default_value"]).to be_nil
-    end
-  end
-
-  context "workspace has service template other than orchestration" do
-    let(:service_template) { FactoryGirl.create(:service_template) }
-
-    it "provides only default value to the flavor list" do
-      ws = MiqAeEngine.instantiate("#{@ins}?ServiceTemplate::service_template=#{service_template.id}", user)
-      expect(ws.root["values"]).to eq(nil => default_desc)
-      expect(ws.root["default_value"]).to be_nil
-    end
-  end
-
-  let(:ems) do
-    @flavor1 = FactoryGirl.create(:flavor, :name => 'flavor1')
-    @flavor2 = FactoryGirl.create(:flavor, :name => 'flavor2')
-    FactoryGirl.create(:ems_openstack, :flavors => [@flavor1, @flavor2])
-  end
-
-  context "workspace has orchestration service template" do
-    let(:service_template) do
-      FactoryGirl.create(:service_template_orchestration, :orchestration_manager => ems)
-    end
-
-    let(:service_template_no_ems) do
-      FactoryGirl.create(:service_template_orchestration)
-    end
-
-    it "finds all the flavors and populates the list" do
-      ws = MiqAeEngine.instantiate("#{@ins}?ServiceTemplate::service_template=#{service_template.id}", user)
-      expect(ws.root["values"]).to include(
-        nil           => "<Choose>",
-        @flavor1.name => @flavor1.name,
-        @flavor2.name => @flavor2.name
-      )
-      expect(ws.root["default_value"]).to be_nil
-    end
-
-    it "provides only default value to the flavor list if orchestration manager does not exist" do
-      ws = MiqAeEngine.instantiate("#{@ins}?ServiceTemplate::service_template=#{service_template_no_ems.id}", user)
-      expect(ws.root["values"]).to eq(nil => default_desc)
-      expect(ws.root["default_value"]).to be_nil
-    end
-  end
-
-  context "workspace has orchestration service" do
-    let(:service) do
-      FactoryGirl.create(:service_orchestration, :orchestration_manager => ems)
-    end
-
-    let(:service_no_ems) do
-      FactoryGirl.create(:service_orchestration)
-    end
-
-    it "finds all the flavors and populates the list" do
-      ws = MiqAeEngine.instantiate("#{@ins}?Service::service=#{service.id}", user)
-      expect(ws.root["values"]).to include(
-        nil           => "<Choose>",
-        @flavor1.name => @flavor1.name,
-        @flavor2.name => @flavor2.name
-      )
-      expect(ws.root["default_value"]).to be_nil
-    end
-
-    it "provides only default value to the flavor list if orchestration manager does not exist" do
-      ws = MiqAeEngine.instantiate("#{@ins}?Service::service=#{service_no_ems.id}", user)
-      expect(ws.root["values"]).to eq(nil => default_desc)
-      expect(ws.root["default_value"]).to be_nil
-    end
-  end
-end
diff --git a/spec/db/fixtures/ae_datastore/ManageIQ/Cloud/Orchestration/Operations/Methods.class/__methods__/available_flavors_spec.rb b/spec/db/fixtures/ae_datastore/ManageIQ/Cloud/Orchestration/Operations/Methods.class/__methods__/available_flavors_spec.rb
new file mode 100644
index 00000000000..6333e948efa
--- /dev/null
+++ b/spec/db/fixtures/ae_datastore/ManageIQ/Cloud/Orchestration/Operations/Methods.class/__methods__/available_flavors_spec.rb
@@ -0,0 +1,119 @@
+require Rails.root.join('db/fixtures/ae_datastore/ManageIQ/Cloud/Orchestration/Operations' \
+                        '/Methods.class/__methods__/available_flavors.rb').to_s
+
+describe ManageIQ::Automate::Cloud::Orchestration::Operations::AvailableFlavors do
+  let(:root_object) { Spec::Support::MiqAeMockObject.new(root_hash) }
+  let(:root_hash) do
+    { 'service_template' => MiqAeMethodService::MiqAeServiceServiceTemplate.find(service_template.id) }
+  end
+  let(:ae_service) do
+    Spec::Support::MiqAeMockService.new(root_object).tap do |service|
+      current_object = Spec::Support::MiqAeMockObject.new
+      current_object.parent = root_object
+      service.object = current_object
+    end
+  end
+
+  shared_examples_for "#having only default value" do
+    let(:default_desc_blank) { "<none>" }
+
+    it "provides only default value to the flavor list" do
+      described_class.new(ae_service).main
+
+      expect(ae_service["values"]).to eq(nil => default_desc_blank)
+      expect(ae_service["default_value"]).to be_nil
+    end
+  end
+
+  shared_examples_for "#having all flavors" do |service_type|
+    let(:default_desc) { "<select>" }
+    let(:flavor1) { FactoryGirl.create(:flavor, :name => 'flavor1') }
+    let(:flavor2) { FactoryGirl.create(:flavor, :name => 'flavor2') }
+    let(:ems) { FactoryGirl.create(:ems_openstack, :flavors => [flavor1, flavor2]) }
+
+    let(:svc_model_flavor1) do
+      MiqAeMethodService::MiqAeServiceFlavor.find(flavor1.id)
+    end
+
+    let(:svc_model_flavor2) do
+      MiqAeMethodService::MiqAeServiceFlavor.find(flavor2.id)
+    end
+
+    let(:svc_model_orchestration_manager) do
+      MiqAeMethodService::MiqAeServiceExtManagementSystem.find(ems.id)
+    end
+
+    let(:svc_model_service) do
+      root_hash["service_template"] || root_hash["service"]
+    end
+
+    it "finds all the flavors and populates the list" do
+      allow(ae_service.root).to receive(:attributes)
+        .and_return(service_type => svc_model_service)
+      allow(svc_model_service).to receive(:orchestration_manager)
+        .and_return(svc_model_orchestration_manager)
+      allow(svc_model_orchestration_manager).to receive(:flavors)
+        .and_return([svc_model_flavor1, svc_model_flavor2])
+      described_class.new(ae_service).main
+
+      expect(ae_service["values"]).to include(
+        nil          => default_desc,
+        flavor1.name => flavor1.name,
+        flavor2.name => flavor2.name
+      )
+      expect(ae_service["default_value"]).to be_nil
+    end
+  end
+
+  context "workspace has no service template" do
+    let(:root_hash) { {} }
+
+    it_behaves_like "#having only default value"
+  end
+
+  context "workspace has service template other than orchestration" do
+    let(:service_template) { FactoryGirl.create(:service_template) }
+
+    it_behaves_like "#having only default value"
+  end
+
+  context "workspace has orchestration service template" do
+    context 'with orchestration_manager' do
+      let(:service_template) do
+        FactoryGirl.create(:service_template_orchestration, :orchestration_manager => ems)
+      end
+
+      it_behaves_like "#having all flavors", "service_template"
+    end
+
+    context 'without orchestration_manager' do
+      let(:service_template) do
+        FactoryGirl.create(:service_template_orchestration)
+      end
+
+      it_behaves_like "#having only default value"
+    end
+  end
+
+  context "workspace has orchestration service" do
+    let(:root_hash) do
+      { 'service' => MiqAeMethodService::MiqAeServiceService.find(service.id) }
+    end
+
+    context 'with orchestration_manager' do
+      let(:service) do
+        FactoryGirl.create(:service_orchestration, :orchestration_manager => ems)
+      end
+
+      it_behaves_like "#having all flavors", "service"
+    end
+
+    context 'without orchestration_manager' do
+      let(:service) do
+        FactoryGirl.create(:service_orchestration)
+      end
+
+      it_behaves_like "#having only default value"
+    end
+  end
+end