From 6458a385f0e9a3c83438e4bdf26d2990933f2ec6 Mon Sep 17 00:00:00 2001 From: Parker Timmerman Date: Tue, 12 Nov 2024 10:58:30 -0500 Subject: [PATCH] temporily ignore breaking changes on some proto files since buf doesn't know any better' --- src/buf.yaml | 12 ++++++++++++ src/repr/src/relation_and_scalar.proto | 2 ++ src/storage-types/src/connections.proto | 2 ++ src/storage-types/src/sinks.proto | 2 ++ src/storage-types/src/sources/kafka.proto | 2 ++ src/storage-types/src/sources/mysql.proto | 2 ++ src/storage-types/src/sources/postgres.proto | 5 ++++- 7 files changed, 26 insertions(+), 1 deletion(-) diff --git a/src/buf.yaml b/src/buf.yaml index 1f642fed9f9ed..90fe4d58cab83 100644 --- a/src/buf.yaml +++ b/src/buf.yaml @@ -49,14 +49,26 @@ breaking: - compute-types/src/sinks.proto # reason: Ignore because plans are currently not persisted. - expr/src/relation.proto + # reason: temporarily ignored by ParkMyCar + - repr/src/relation_and_scalar.proto # reason: does currently not require backward-compatibility - storage-client/src/client.proto # reason: does currently not require backward-compatibility - storage-client/src/statistics.proto + # reason: temporarily ignored by ParkMyCar + - storage-types/src/connections.proto # reason: currently does not require backward-compatibility - storage-types/src/connections/aws.proto # reason: currently does not require backward-compatibility - storage-types/src/connections/string_or_secret.proto + # reason: temporarily ignored by ParkMyCar + - storage-types/src/sinks.proto + # reason: temporarily ignored by ParkMyCar + - storage-types/src/sources/kafka.proto + # reason: temporarily ignored by ParkMyCar + - storage-types/src/sources/mysql.proto + # reason: temporarily ignored by ParkMyCar + - storage-types/src/sources/postgres.proto lint: use: - DEFAULT diff --git a/src/repr/src/relation_and_scalar.proto b/src/repr/src/relation_and_scalar.proto index d64b38bf2fa87..7c65aeafa7480 100644 --- a/src/repr/src/relation_and_scalar.proto +++ b/src/repr/src/relation_and_scalar.proto @@ -10,6 +10,8 @@ // Note: protobuf does not support cyclic imports. Thus, this file contains // both, definitions from relation.rs and scalar.rs +// buf breaking: ignore (temporarily ignored by ParkMyCar) + syntax = "proto3"; package mz_repr.relation_and_scalar; diff --git a/src/storage-types/src/connections.proto b/src/storage-types/src/connections.proto index 77b4aa64e0d29..30e2f13ad0ea4 100644 --- a/src/storage-types/src/connections.proto +++ b/src/storage-types/src/connections.proto @@ -7,6 +7,8 @@ // the Business Source License, use of this software will be governed // by the Apache License, Version 2.0. +// buf breaking: ignore (temporarily ignored by ParkMyCar) + syntax = "proto3"; package mz_storage_types.connections; diff --git a/src/storage-types/src/sinks.proto b/src/storage-types/src/sinks.proto index a943f9a739f66..562f9fa1828a1 100644 --- a/src/storage-types/src/sinks.proto +++ b/src/storage-types/src/sinks.proto @@ -7,6 +7,8 @@ // the Business Source License, use of this software will be governed // by the Apache License, Version 2.0. +// buf breaking: ignore (temporarily ignored by ParkMyCar) + syntax = "proto3"; package mz_storage_types.sinks; diff --git a/src/storage-types/src/sources/kafka.proto b/src/storage-types/src/sources/kafka.proto index 2336541cbc868..fd359daa89d16 100644 --- a/src/storage-types/src/sources/kafka.proto +++ b/src/storage-types/src/sources/kafka.proto @@ -7,6 +7,8 @@ // the Business Source License, use of this software will be governed // by the Apache License, Version 2.0. +// buf breaking: ignore (temporarily ignored by ParkMyCar) + syntax = "proto3"; package mz_storage_types.sources.kafka; diff --git a/src/storage-types/src/sources/mysql.proto b/src/storage-types/src/sources/mysql.proto index f4fc6c91b0961..3347cb107caf1 100644 --- a/src/storage-types/src/sources/mysql.proto +++ b/src/storage-types/src/sources/mysql.proto @@ -7,6 +7,8 @@ // the Business Source License, use of this software will be governed // by the Apache License, Version 2.0. +// buf breaking: ignore (temporarily ignored by ParkMyCar) + syntax = "proto3"; package mz_storage_types.sources.mysql; diff --git a/src/storage-types/src/sources/postgres.proto b/src/storage-types/src/sources/postgres.proto index 9ab12e8817fe2..e8f9307ee4482 100644 --- a/src/storage-types/src/sources/postgres.proto +++ b/src/storage-types/src/sources/postgres.proto @@ -7,6 +7,8 @@ // the Business Source License, use of this software will be governed // by the Apache License, Version 2.0. +// buf breaking: ignore (temporarily ignored by ParkMyCar) + syntax = "proto3"; package mz_storage_types.sources.postgres; @@ -52,7 +54,8 @@ message ProtoPostgresSourceExportDetails { // NOTE: this message is encoded and stored as part of source export // statement options -// Be extra careful about changes, ensuring that all changes are backwards compatible +// Be extra careful about changes, ensuring that all changes are backwards +// compatible message ProtoPostgresSourceExportStatementDetails { mz_postgres_util.desc.ProtoPostgresTableDesc table = 1; }