Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimum and Maximum Event Level Not Working #257

Open
theeneon opened this issue Jan 7, 2025 · 2 comments · May be fixed by #262
Open

Minimum and Maximum Event Level Not Working #257

theeneon opened this issue Jan 7, 2025 · 2 comments · May be fixed by #262
Assignees
@MathiasGruber
Labels
bug Something isn't working fix-me Assigning this label will let OpenHands AI attempt to fix the issue and create a PR.

Comments

@theeneon
Copy link
Collaborator

theeneon commented Jan 7, 2025 •
edited
Loading

Describe the bug
Players are able to accept events that they don't meat the minimum or maximum level for

To Reproduce
Steps to reproduce the behavior:

  1. Create an event
  2. Set a Minium or maximum level
  3. The event still shows up in Wake Island for players who don't meet the minimum or maximum level

Solution:
Events must only show up for players based on the minimum and maximum level that is set
@theeneon theeneon added bug Something isn't working fix-me Assigning this label will let OpenHands AI attempt to fix the issue and create a PR. labels Jan 7, 2025
@TheNinja-RPG
Copy link
Collaborator

OpenHands started fixing the issue! You can monitor the progress here.

TheNinja-RPG pushed a commit that referenced this issue Jan 9, 2025
@openhands-agent
Fix issue #257: Minimum and Maximum Event Level Not Working
2857b93
@TheNinja-RPG
Copy link
Collaborator

A potential fix has been generated and a draft PR #262 has been created. Please review the changes.

@TheNinja-RPG TheNinja-RPG linked a pull request Jan 9, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MathiasGruber MathiasGruber

Labels
bug Something isn't working fix-me Assigning this label will let OpenHands AI attempt to fix the issue and create a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issue #257: Minimum and Maximum Event Level Not Working MathiasGruber/TheNinjaRPG
3 participants
@MathiasGruber @theeneon @TheNinja-RPG